Add more support for OpenBSD #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the backtrace example would print a useless backtrace:
Running `target/debug/examples/backtrace`
0: <unknown>
1: <unknown>
2: <unknown>
3: <unknown>
4: <unknown>
5: <unknown>
6: <unknown>
7: <unknown>
Now its slightly more useful
Running `target/debug/examples/backtrace`
0: backtrace::main
at examples/backtrace.rs:4:22
1: core::ops::function::FnOnce::call_once
at /usr/obj/ports/rust-1.54.0/rustc-1.54.0-src/library/core/src/ops/function.rs:227:5
2: std::sys_common::backtrace::__rust_begin_short_backtrace
at /usr/obj/ports/rust-1.54.0/rustc-1.54.0-src/library/std/src/sys_common/backtrace.rs:125:18
3: std::rt::lang_start::{{closure}}
at /usr/obj/ports/rust-1.54.0/rustc-1.54.0-src/library/std/src/rt.rs:49:18
4: std::rt::lang_start_internal
5: std::rt::lang_start
at /usr/obj/ports/rust-1.54.0/rustc-1.54.0-src/library/std/src/rt.rs:48:5
6: main
7: <unknown>
I do not know for sure why it cannot trace back to before main, could be a bug
in backtrace-rs or a security measure by OpenBSD. However for the average user
this step of the backtrace should be irrelevant on OpenBSD so this is still a
great improvement to before.
|
Indeed that is much better than before, thanks! |
|
Do I have to do anything special to get the upstream rustc to use this updated version of backtrace? Or is it just regularly updated as a chore for every release? @alexcrichton |
|
The |
hargoniX
added a commit
to hargoniX/rust
that referenced
this pull request
Sep 15, 2021
rust-lang/backtrace-rs#437 fixed backtraces in OpenBSD -> update it here as well so OpenBSD Rust code can produce proper backtraces.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 16, 2021
Update the backtrace crate rust-lang/backtrace-rs#437 fixed backtraces in OpenBSD -> update it here as well so OpenBSD Rust code can produce proper backtraces.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 16, 2021
Update the backtrace crate rust-lang/backtrace-rs#437 fixed backtraces in OpenBSD -> update it here as well so OpenBSD Rust code can produce proper backtraces.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 16, 2021
Update the backtrace crate rust-lang/backtrace-rs#437 fixed backtraces in OpenBSD -> update it here as well so OpenBSD Rust code can produce proper backtraces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the backtrace example would print a useless backtrace:
Now its slightly more useful
I do not know for sure why it cannot trace back to before main, could be a bug
in backtrace-rs or a security measure by OpenBSD. However for the average user
this step of the backtrace should be irrelevant on OpenBSD so this is still a
great improvement to before.